Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of example for parameters extraction #1528

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

pmaroneh
Copy link
Contributor

@pmaroneh pmaroneh commented Oct 5, 2022

Due to recent changes with parameters this example needs to be adjusted for the last section :
mapdl.vget("frequencies(1)", 1)
mapdl.vget("response(1)", 3)
become:
mapdl.vget("frequencies", 1)
mapdl.vget("response", 3)

@pmaroneh pmaroneh requested a review from germa89 October 5, 2022 09:28
@pmaroneh pmaroneh added the Documentation Documentation related (improving, adding, etc) label Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #1528 (53db5cc) into main (5a1d529) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1528   +/-   ##
=======================================
  Coverage   81.80%   81.80%           
=======================================
  Files          43       43           
  Lines        6797     6797           
=======================================
  Hits         5560     5560           
  Misses       1237     1237           

@germa89
Copy link
Collaborator

germa89 commented Oct 5, 2022

Hi @pmaroneh

Thank you for your PR!?

I wonder @pmaroneh, @RGPATCHI and @mikerife if we should support also parameter(1)?? I am thinking on the converter module, I believe it will translate to parameter(1)...
So we should probably support that?? Or change also the converter module. But I am also considering the case vget,parameter(1,2)... where the second column will be used.

I need to think a bit more about this....

@pmaroneh pmaroneh self-assigned this Oct 5, 2022
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge @pmaroneh ! And thank you for your contribution! :)

@germa89 germa89 merged commit 7f95006 into main Oct 24, 2022
@germa89 germa89 deleted the doc_techdemos_20_correction branch October 24, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants