Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements to logging #1600

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Small improvements to logging #1600

merged 4 commits into from
Nov 2, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 31, 2022

Small improvements:

  • Removing over logging in licensing
  • Accepting lower case log levels.

@germa89 germa89 added the Enhancement Improve any current implemented feature label Oct 31, 2022
@germa89 germa89 self-assigned this Oct 31, 2022
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022 •
edited

Codecov Report

Merging #1600 (1ba093d) into main (2db825a) will increase coverage by 0.21%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main    #1600      +/-   ##
==========================================
+ Coverage   82.71%   82.92%   +0.21%     
==========================================
  Files          44       44              
  Lines        7143     7151       +8     
==========================================
+ Hits         5908     5930      +22     
+ Misses       1235     1221      -14

@germa89
Copy link
Collaborator Author

germa89 commented Nov 2, 2022

LGTM.

@germa89 germa89 merged commit c435758 into main Nov 2, 2022
@germa89 germa89 deleted the feat/small-improvements-to-logger branch November 2, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@germa89 germa89

Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@germa89