-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General edit of Krylov example #1605
Conversation
Please add one of the following labels to add this contribution to the Release Notes 👇 |
Codecov Report
@@ Coverage Diff @@
## main #1605 +/- ##
==========================================
+ Coverage 82.71% 82.82% +0.11%
==========================================
Files 44 44
Lines 7143 7151 +8
==========================================
+ Hits 5908 5923 +15
+ Misses 1235 1228 -7 |
Thanks so much for the review @PipKat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions, but it looks good to me.
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
I'm happy to meet you anytime @PipKat :) |
Add German's review comments Co-authored-by: German <28149841+germa89@users.noreply.github.com>
…pymapdl into docs/edit_Kylov_example
Here's the edited file. I'm going to leave a few comments/questions. Note that the existing Examples section needs to be reworked to following Google developer style guidelines. If you want to see better examples, look at those for PyAEDT. I also want to talk to German about breaking out the example sections in separate RST files so that the TOC for this section makes more sense.