Reviewing basic DPF example #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
added
Enhancement
Codecov Report
@@ Coverage Diff @@
## main #1607 +/- ##
==========================================
+ Coverage 79.52% 82.81% +3.28%
==========================================
Files 44 44
Lines 7151 7151
==========================================
+ Hits 5687 5922 +235
+ Misses 1464 1229 -235 |
|
@PipKat let me know when you have had a look at this :) |
PipKat
reviewed
Nov 4, 2022
PipKat
reviewed
Nov 4, 2022
PipKat
reviewed
Nov 4, 2022
PipKat
approved these changes
Nov 4, 2022
germa89
commented
Nov 4, 2022
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
|
This is perfect. Thank you @PipKat !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing grammar and coding style.
Please @PipKat could you give me a hand on this whenever you have time?
You can find a first render of this example here: https://dev.mapdl.docs.pyansys.com/examples/gallery_examples/00-mapdl-examples/basic_dpf_example.html