Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu image to run as local #1615

Merged
merged 51 commits into from
Nov 29, 2022
Merged

Use ubuntu image to run as local #1615

merged 51 commits into from
Nov 29, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 6, 2022

This job at the main workflow file ci.yml aims to make possible to run pytest from inside the ubuntu MAPDL container in local configuration.

I have also habilitated the skipped tests.

Notes

  • I hit a problem with the test test_remove_temp_files_fail which I have disable it for the moment.
  • I also hit problems when closing the MAPDL process. It seems the processes are not killed properly or are bad referenced. The lines in question are:
            # time.sleep(1)  # takes a second for the processes to shutdown
            # for pid in mapdl._pids:
            #     assert not check_pid(pid)

I will fix this later in a follow up PR.

Outcomes

  • Coverage have been increased by 2.7% (it is not much, but a follow up PR should investigate this).
  • The number of tests run are:
    • Ubuntu: 993 passed, 186 skipped, 29 deselected, 108 xfailed, 2 xpassed in 552.41s (0:09:12)
    • Normal v22.2: 956 passed, 252 skipped, 108 xfailed, 2 xpassed in 175.36s (0:02:55)

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Nov 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #1615 (32db21f) into main (71d9677) will increase coverage by 2.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1615      +/-   ##
==========================================
+ Coverage   82.74%   85.25%   +2.50%     
==========================================
  Files          44       45       +1     
  Lines        7151     7465     +314     
==========================================
+ Hits         5917     6364     +447     
+ Misses       1234     1101     -133     

@germa89 germa89 changed the title Use ubuntu image Use ubuntu image to run as local Nov 7, 2022
@germa89 germa89 mentioned this pull request Nov 7, 2022
@germa89
Copy link
Collaborator Author

germa89 commented Nov 22, 2022

The docker image has been updated to Ubuntu 22.04.

@germa89
Copy link
Collaborator Author

germa89 commented Nov 22, 2022

I'm going to have to implement something equivalent to --restart always on the windows local machine. One error and the whole instance crashes.

@germa89
Copy link
Collaborator Author

germa89 commented Nov 24, 2022

The test test_apdl_logging_start seems to keep failing.

I have disabled it for the moment an open #1647 PR to track the issue in the near future.

@germa89 germa89 merged commit e557628 into main Nov 29, 2022
@germa89 germa89 deleted the feat/add-ubuntu-image branch November 29, 2022 13:11
@germa89
Copy link
Collaborator Author

germa89 commented Nov 29, 2022

Windows tests are picky... super picky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc DO NOT MERGE Not ready to be merged yet Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants