Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Windows testing #1616

Merged
merged 13 commits into from
Nov 22, 2022
Merged

Adding Windows testing #1616

merged 13 commits into from
Nov 22, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 6, 2022 •
edited

Adding windows testing, running on a self-hosted runner.

Changes in unit test run:

  • Windows: 1030 passed, 143 skipped, 29 deselected, 113 xfailed, 3 xpassed in 539.46s (0:08:59)
  • Ubuntu v22.2: 956 passed, 252 skipped, 108 xfailed, 2 xpassed in 146.57s (0:02:26)

To be merged after #1615

@germa89 germa89 self-assigned this Nov 6, 2022
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Nov 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Nov 6, 2022 •
edited

Codecov Report

Merging #1616 (83ad2c7) into main (9392c8a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1616   +/-   ##
=======================================
  Coverage   82.84%   82.84%           
=======================================
  Files          44       44           
  Lines        7151     7151           
=======================================
  Hits         5924     5924           
  Misses       1227     1227

@germa89
Copy link
Collaborator Author

germa89 commented Nov 18, 2022 •
edited

Close #630

@germa89 germa89 mentioned this pull request Nov 22, 2022
Closed
@germa89 germa89 merged commit aab9d49 into main Nov 22, 2022
@germa89 germa89 deleted the feat/Windows-testing branch November 22, 2022 19:57
@germa89
Copy link
Collaborator Author

germa89 commented Nov 22, 2022 •
edited

Finally merged!

@RobPasMue
Copy link
Member

RobPasMue commented Nov 23, 2022 •
edited

Finally merged!

Haha! No pain, no gain =)

@germa89
Copy link
Collaborator Author

germa89 commented Nov 23, 2022

Finally merged!

Haha! No pain, no gain =)

Totally 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koubaa koubaa koubaa approved these changes

@akaszynski akaszynski Awaiting requested review from akaszynski

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
PyMAPDL Public Roadmap
Status: Q4 2022-Oct-Dec
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@germa89 @RobPasMue @koubaa