Implementing vale

[RobPasMue]

Closes #1623

[github-actions]

Please add one of the following labels to add this contribution to the Release Notes 👇

• BUG
• NEW FEATURE
• Enhancement
• Documentation
• Examples
• Maintenance
• CI/CD

[codecov]

Codecov Report

Merging #1644 (77bd44e) into main (826a820) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1644      +/-   ##
==========================================
+ Coverage   82.74%   82.84%   +0.09%     
==========================================
  Files          44       44              
  Lines        7151     7151              
==========================================
+ Hits         5917     5924       +7     
+ Misses       1234     1227       -7     

[RobPasMue]

Okay @PipKat all yours =)

If you need any help, let me know.

[PipKat]

@RobPasMue I am presently working on this. There's just a lot of issues to resolve! I see a message about a conflict. Do we wait until I push my commits to worry about this? I've made one commit but not pushed anything yet.

[RobPasMue]

@PipKat let's worry about the conflicts later. I hope that they are not critical honestly =)

PS.: from what I can tell it's only the workflow for now.

[PipKat]

@RobPasMue I asked Alex mid-afternoon on Friday whether I could edit the RST files in the mapdl_commands folder but he never responded. I would think they were introductions to the XML imports, but I don't know. Consequently, there are still errors. In some places I tried to use the and tags, but they seem to work only in an actual PR. I wanted something pushed in case you wanted to get this done before I returned on Monday. Let me know the status then. Thanks!

[RobPasMue]

I'll have a look at it @PipKat don't worry =) Happy Thanksgiving!!

[RobPasMue]

I think I got it @PipKat =) the mapdl_commands folder inside the documentation could be edited without a problem. So we are good to go there. I solved all the remaining vale warnings and errors. This PR is ready for review though... it's going to be tough 😄

Pinging @germa89 for review

[germa89]

Good job @PipKat and @RobPasMue . Just some minor changes. Feel free to merge after conversations are resolved.

[RobPasMue]

This should be now good to go. Let's wait for the workflow to run =)

[RobPasMue]

Workflow succeeded! Merging =)

[PipKat]

@RobPasMue Thanks for handling this and getting it merged!

[germa89]

PyMAPDL windows testing is flaky... So... ignore it. Who cares about Windows anyway? xD