Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docker-compose files #1659

Merged
merged 13 commits into from
Nov 30, 2022
Merged

Adding docker-compose files #1659

merged 13 commits into from
Nov 30, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 29, 2022

Cleaning a bit the docker directory.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc) labels Nov 29, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1659 (512d587) into main (4a6d57d) will decrease coverage by 0.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1659      +/-   ##
==========================================
- Coverage   82.84%   82.01%   -0.83%     
==========================================
  Files          44       44              
  Lines        7151     7156       +5     
==========================================
- Hits         5924     5869      -55     
- Misses       1227     1287      +60     

Copy link
Contributor

@koubaa koubaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand everything here but I don't see any issues

@germa89
Copy link
Collaborator Author

germa89 commented Nov 30, 2022

I'm not sure I understand everything here but I don't see any issues

Well... the idea is now you can use MAPDL in Mac for example. We are providing the full setup files to having it running in remote, local and/or with license server (discouraged).
For people working in Mac, it is very easy to run MAPDL now, just copy the docker files, set the env vars, and use docker-compose command.

@germa89 germa89 enabled auto-merge (squash) November 30, 2022 12:55
@germa89 germa89 merged commit e53d3d8 into main Nov 30, 2022
@germa89 germa89 deleted the Adding-docker-files branch November 30, 2022 15:54
@germa89
Copy link
Collaborator Author

germa89 commented Nov 30, 2022

@PipKat I forgot to mention you in this PR. Feel free to have a read an propose any changes in another PR. Sorry about that!

@PipKat
Copy link
Member

PipKat commented Dec 2, 2022

@germa89 No worries! I'll take a look at these sections and edit them when I can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants