Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits for demo #1668

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Minor edits for demo #1668

merged 2 commits into from
Dec 6, 2022

Conversation

PipKat
Copy link
Member

@PipKat PipKat commented Dec 1, 2022

Please approve minor edits made during demo. I wanted to show Mechanical writers the process. I tried to run the failing unit test on Windows a few times. I hope it finally runs or that you can fix the issue!

@PipKat PipKat requested a review from germa89 December 1, 2022 20:32
@github-actions github-actions bot added the Documentation Documentation related (improving, adding, etc) label Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #1668 (5082740) into main (3d2518f) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
- Coverage   81.30%   81.27%   -0.03%     
==========================================
  Files          45       45              
  Lines        7466     7466              
==========================================
- Hits         6070     6068       -2     
- Misses       1396     1398       +2     

@germa89
Copy link
Collaborator

germa89 commented Dec 2, 2022

Hi @PipKat, thank you for this.

Indeed, the windows check is veeeeery flaky.... So do not bother with it. ;)

@PipKat
Copy link
Member Author

PipKat commented Dec 2, 2022

Hi @PipKat, thank you for this.

Indeed, the windows check is veeeeery flaky.... So do not bother with it. ;)

The PR can't be merged until this check is successful--so someone has to bother?! I'm rerunning it again....
Also, the following check failed, but I don't see a way to try to rerun it:
image

@germa89
Copy link
Collaborator

germa89 commented Dec 2, 2022

Hi @PipKat, thank you for this.
Indeed, the windows check is veeeeery flaky.... So do not bother with it. ;)

The PR can't be merged until this check is successful--so someone has to bother?! I'm rerunning it again.... Also, the following check failed, but I don't see a way to try to rerun it: image

hahaha. Windows check is not required, so you can merge without it passing. The vXX.X.X are required thought. Don't worry. I will take care of it. :)

@germa89 germa89 merged commit 5f30d59 into main Dec 6, 2022
@germa89 germa89 deleted the doc/simple_edits_for_demo branch December 6, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants