Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizing the headers #1689

Merged
merged 19 commits into from
Dec 15, 2022
Merged

Reorganizing the headers #1689

merged 19 commits into from
Dec 15, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 13, 2022

By popular demand.

@PipKat although there is some renaming, I did not change anything in API directory. Have a look at the other files (docker, wsl, etc)
I'm merging tonight so if you cannot have a look today, feel free to open a later PR.

@Revathyvenugopal162 ... Finally you got it! xD

Close #1688
Close #1620

@germa89 germa89 added the Documentation Documentation related (improving, adding, etc) label Dec 13, 2022
@germa89 germa89 self-assigned this Dec 13, 2022
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Dec 13, 2022
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eagerly waiting to see the new layout!.

doc/source/user_guide/troubleshoot.rst Outdated Show resolved Hide resolved
doc/source/user_guide/troubleshoot.rst Outdated Show resolved Hide resolved
germa89 and others added 2 commits December 14, 2022 10:26
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #1689 (29d24e9) into main (54639d2) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1689      +/-   ##
==========================================
+ Coverage   85.23%   85.27%   +0.03%     
==========================================
  Files          45       45              
  Lines        7506     7506              
==========================================
+ Hits         6398     6401       +3     
+ Misses       1108     1105       -3     

Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! Thanks!

@germa89
Copy link
Collaborator Author

germa89 commented Dec 15, 2022

Regarding #1688

I have decided to NOT join both sections. The WSL section is more specific than docker and it has its complexities.

germa89 and others added 3 commits December 15, 2022 16:13
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@germa89 germa89 merged commit 5e57a31 into main Dec 15, 2022
@germa89 germa89 deleted the doc/reog-headers branch December 15, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging WSL and Docker sections Modify the upper bar in the docs
3 participants