Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the PyMAPDL architecture diagram #1733

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Adding the PyMAPDL architecture diagram #1733

merged 1 commit into from
Dec 23, 2022

Conversation

clatapie
Copy link
Contributor

Closes #1721

@clatapie clatapie self-assigned this Dec 22, 2022
@clatapie clatapie linked an issue Dec 22, 2022 that may be closed by this pull request
Include pymapdl structure graph #1721
Closed
@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc) labels Dec 22, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Dec 22, 2022 •
edited

Codecov Report

Merging #1733 (720d207) into main (5e57a31) will increase coverage by 0.12%.
The diff coverage is 68.00%.

@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
+ Coverage   85.26%   85.38%   +0.12%     
==========================================
  Files          45       45              
  Lines        7506     7522      +16     
==========================================
+ Hits         6400     6423      +23     
+ Misses       1106     1099       -7

germa89
germa89 approved these changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@germa89 germa89 marked this pull request as ready for review December 23, 2022 11:59
@germa89 germa89 merged commit e8c02fc into main Dec 23, 2022
@germa89 germa89 deleted the maint/include_struct_graph branch December 23, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germa89 germa89 germa89 approved these changes

@RobPasMue RobPasMue Awaiting requested review from RobPasMue

Assignees

@clatapie clatapie

Labels
Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include pymapdl structure graph
2 participants
@clatapie @germa89