Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating pre-commit #1820

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Updating pre-commit #1820

merged 1 commit into from
Jan 30, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 30, 2023

Updating pre-commit with isort fix.

Thanks to @RobPasMue

@germa89 germa89 self-assigned this Jan 30, 2023
@germa89 germa89 added BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc labels Jan 30, 2023
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@RobPasMue
Copy link
Member

I'm guessing pre-commit.ci would have opened that PR eventually but thanks for fixing it =)

@germa89 germa89 requested review from a team and clatapie and removed request for a team January 30, 2023 11:58
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #1820 (c6d9162) into main (8f915b4) will increase coverage by 85.65%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           main    #1820       +/-   ##
=========================================
+ Coverage      0   85.65%   +85.65%     
=========================================
  Files         0       44       +44     
  Lines         0     7809     +7809     
=========================================
+ Hits          0     6689     +6689     
- Misses        0     1120     +1120     

@germa89
Copy link
Collaborator Author

germa89 commented Jan 30, 2023

I'm guessing pre-commit.ci would have opened that PR eventually but thanks for fixing it =)

Yeah.. it should... but we need it for other PRs:

https://results.pre-commit.ci/run/github/70696039/1675076962.ZleHVrOAQMuSSdJEP_shPg

@germa89 germa89 merged commit 5584b6b into main Jan 30, 2023
@germa89 germa89 deleted the fix/update-precommit branch January 30, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants