Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some tests #1838

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Fixing some tests #1838

merged 4 commits into from
Feb 2, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 1, 2023

Just fixing some tests

  • test_remove_temp_files_fail
  • test_remove_temp_files
  • test_launch_corba - Cancelled. It seem fine?
  • test_load_table (corba mode)
  • test_apdl_logging_start
  • test_heal
  • test_license_type_additional_switch
  • test_set_list
  • test_krylov_with_pressure_load
  • test_simple

Close #1806

@germa89 germa89 added the Enhancement Improve any current implemented feature label Feb 1, 2023
@germa89 germa89 self-assigned this Feb 1, 2023
@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #1838 (8d8e684) into main (16ccd89) will decrease coverage by 4.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
- Coverage   85.69%   80.74%   -4.96%     
==========================================
  Files          44       44              
  Lines        7811     7810       -1     
==========================================
- Hits         6694     6306     -388     
- Misses       1117     1504     +387     

@germa89 germa89 marked this pull request as ready for review February 1, 2023 22:25
@germa89 germa89 enabled auto-merge (squash) February 2, 2023 11:17
@germa89 germa89 requested a review from clatapie February 2, 2023 11:19
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit cb7d0b1 into main Feb 2, 2023
@germa89 germa89 deleted the fix/some-tests branch February 2, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_remove_temp_files_fail is not coherent
2 participants