-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code update for Ansvec __getitem__ to handle complex dtype #1882
Conversation
Please add one of the following labels to add this contribution to the Release Notes 👇 |
Codecov Report
@@ Coverage Diff @@
## main #1882 +/- ##
==========================================
- Coverage 85.86% 85.72% -0.14%
==========================================
Files 44 44
Lines 7844 7853 +9
==========================================
- Hits 6735 6732 -3
- Misses 1109 1121 +12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Thank you @kmkoshy. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware how MAPDL stores de complex numbers. It seems it is just an array with two columns. Always there is something to learn!
Good PR. Nice pick.
Thank you @kmkoshy :)
Updating feedback Co-authored-by: German <28149841+germa89@users.noreply.github.com>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me. 😄
Code change to handle Issue #1881
Description of the Issue :
Indexing Items from a AnsVec of complex datatype which has both real and imag values, returns only the real value.
There is no way of accessing the imaginary value unless AnsVec is changed to numpy array.
Close #1881