Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading PIM interface #1925

Merged
merged 5 commits into from
Mar 16, 2023
Merged

Upgrading PIM interface #1925

merged 5 commits into from
Mar 16, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 15, 2023

Adding version to PIM.create instance.

@germa89
Copy link
Collaborator Author

germa89 commented Mar 15, 2023

@plule-ansys do you want extra options to be passed?? Like -np or dir. Etc.

@germa89 germa89 self-assigned this Mar 15, 2023
@germa89 germa89 added Enhancement Improve any current implemented feature CI/CD Related with CICD, Github Actions, etc labels Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1925 (a394480) into main (c8f1d75) will increase coverage by 0.08%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #1925      +/-   ##
==========================================
+ Coverage   85.77%   85.85%   +0.08%     
==========================================
  Files          44       44              
  Lines        7875     7878       +3     
==========================================
+ Hits         6755     6764       +9     
+ Misses       1120     1114       -6     

@plule-ansys
Copy link
Contributor

@plule-ansys do you want extra options to be passed?? Like -np or dir. Etc.

Nope, at the moment this is a server-side only configuration, and you can't pass arbitrary command line options

Copy link
Contributor

@plule-ansys plule-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/ansys/mapdl/core/launcher.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/launcher.py Show resolved Hide resolved
@germa89 germa89 enabled auto-merge (squash) March 16, 2023 05:46
@germa89 germa89 merged commit e635bdc into main Mar 16, 2023
@germa89 germa89 deleted the feat/updating-pim-interface branch March 16, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants