-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplying CI #1942
Simplying CI #1942
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1942 +/- ##
=========================================
+ Coverage 0 81.14% +81.14%
=========================================
Files 0 44 +44
Lines 0 7888 +7888
=========================================
+ Hits 0 6401 +6401
- Misses 0 1487 +1487 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this, @germa89. It is always great to simplify things.
I would suggest a couple of things to simplify this a bit more:
Consider using a conditional matrix for macos build, see this example.
Unify naming convetion for job steps. Some of them are using "foo-bar" while others follow "foo_bar".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I agree with @jorgepiloto's suggestion, but I understand why you don't want to put those dependencies. So, it's fine by me 😄 In the end, the workflow dependencies are just a suggestion. Plus, this repo is public... so we are not being charged by running the tests
Reasonable point brought up by @germa89 preventing merge. Accepting implementes changes
Getting rid of the additional workflow which download artifacts from the main workflow.
It has been proben to not be very reliable.