Use scientific notation for big values inl labeled slider #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
- Coverage 87.30% 87.18% -0.13%
==========================================
Files 46 46
Lines 3332 3371 +39
==========================================
+ Hits 2909 2939 +30
- Misses 423 432 +9 ☔ View full report in Codecov by Sentry. |
|
basic idea looks good. lemme know when ready for a full review. How do you plan to manage when it switches into scientific notation? |
|
Currently, it depends on str(float), as for big values, on my machine it uses scientific notation. I need to check how universal it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #224
Use
QLabelinstead ofQDoubleSpinBoxfor custom representation of big/small values.