Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta_data attribute #37

Closed
Sup3rGeo opened this issue Mar 30, 2020 · 1 comment · Fixed by #38
Closed

meta_data attribute #37

Sup3rGeo opened this issue Mar 30, 2020 · 1 comment · Fixed by #38

Comments

@Sup3rGeo
Copy link
Contributor

Hi,

I am trying to list builds based on the value of meta_data variables:

builds = buildkite.builds().list_all_for_pipeline(org_name,
                                                  pipeline_name,
                                                  meta_data={'origin_id': 0}
                                                  )

but it seems that pybuildkite is building the url as ...?metadata={'origin':0}&... instead of ...?metadata[origin]=0&... as defined in Buildkite API documentation.

I checked the unit tests but there doesn't seem to have anything using it.

If this is indeed a bug I would be happy to make a PR to fix it.

@pyasi
Copy link
Owner

pyasi commented Mar 30, 2020

Thanks for the ticket and following PR, I'll take a look as soon as I have time time @Sup3rGeo

@pyasi pyasi closed this as completed in #38 Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants