We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I believe that the functions list_artifacts_for_job and list_artifacts_for_build are inverted:
list_artifacts_for_job
list_artifacts_for_build
pybuildkite/pybuildkite/artifacts.py
Lines 19 to 42 in 5662972
The list_artifacts_for_build should not need a job, only the build. The function that gets a job should be list_artifacts_for_job.
job
build
This is also in line with the API docs: https://buildkite.com/docs/apis/rest-api/artifacts
I would also be happy to open a PR for this one
The text was updated successfully, but these errors were encountered:
Nice find! And you're correct. Let's get this in (and release alongside your other PR for 0.0.6)
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
I believe that the functions
list_artifacts_for_job
andlist_artifacts_for_build
are inverted:pybuildkite/pybuildkite/artifacts.py
Lines 19 to 42 in 5662972
The
list_artifacts_for_build
should not need ajob
, only thebuild
. The function that gets ajob
should belist_artifacts_for_job
.This is also in line with the API docs: https://buildkite.com/docs/apis/rest-api/artifacts
I would also be happy to open a PR for this one
The text was updated successfully, but these errors were encountered: