Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support issuer name in URI generation #2

Merged
merged 3 commits into from Mar 27, 2014

Conversation

jamesob
Copy link

@jamesob jamesob commented Mar 25, 2014

In the Google Authenticator app, if the URI specified doesn't include an issuer_name parameter, the Authenticator entry will lack a title.

This PR brings URI generation in pyotp closer into compliance with Authenticator's key URI format.

@nathforge
Copy link

Thanks for this, looking good - I'd only say that utils.build_uri() should run
issuer_name through urllib.quote, and to change from . import utils to
from pyotp import utils, so we don't break older versions of Python.

@jamesob
Copy link
Author

jamesob commented Mar 26, 2014

@nathforge good calls. Updated.

@kislyuk
Copy link
Member

kislyuk commented Mar 26, 2014

👍 I've been adding the title manually, nice to have it in the library.

@jamesob
Copy link
Author

jamesob commented Mar 27, 2014

this guy ready to go in? anything else to take care of, @nathforge?

@nathforge
Copy link

Nope, just hadn't run tests. All good, thanks James!

nathforge added a commit that referenced this pull request Mar 27, 2014
Support issuer name in URI generation
@nathforge nathforge merged commit 0aef1a8 into pyauth:master Mar 27, 2014
@nathforge
Copy link

1.4.1 uploaded to PyPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants