Correct provisioning_uri method's output #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to the provisioning_uri method in HOTP and TOTP classes the ability to call the util's function build_uri with all the necessary arguments. Added to the function build_uri the ability to handle values different than the defaults for algorithm, digits and period when generating URI.
|
Please fix the lint error. |
|
Also, please add a test case exercising the new options and asserting on the output. |
Made some corrections to pass the standard PEP-008 in all files. Corrected lint errors in docstring in utils' function build_uri. Also corrected an import error for python 2.x and indentation error in utils module.
Current coverage is 39.44% (diff: 70.58%)@@ master #33 diff @@
==========================================
Files 2 2
Lines 109 109
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43 43
Misses 66 66
Partials 0 0
|
|
I will have tests done soon, but since I am using urlencode method to build URL query params and dicts don't have strict elemets order, comparing bare strings is not enough. |
Added the corresponding tests for the new URI generated parameters for both, HOTP and TOTP algorithms. Some earlier tests had to be reformed because now the URI parameters are encoded using urlencode instead of concatenating strings. The string generated by urlencode comes from a dictionary and dictionary items do not have a predefined order. Also corrected some PEP-008 issues.
|
Done. |
|
Great work, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to the provisioning_uri method in HOTP and TOTP classes the
ability to call the util's function build_uri with all the necessary
arguments.
Added to the function build_uri the ability to handle values different
than the defaults for algorithm, digits and period when generating URI.
Closes #32