Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer protocol assumes single plane #26

Closed
mikeboers opened this issue Nov 3, 2013 · 2 comments
Closed

Buffer protocol assumes single plane #26

mikeboers opened this issue Nov 3, 2013 · 2 comments

Comments

@mikeboers
Copy link
Member

This works fine for packed data (e.g. rgb24), but segfaults on planar data (e.g. yuv420p).

Need to decide if we want to export each plane as their own buffer, or somehow pack them.

@mikeboers
Copy link
Member Author

I have created a VideoFormat which allows for easy inspection of formats and components.

I propose the buffer protocol on a frame returns the first plane, and a planes attribute exposes the width/height of that plane along with its buffer.

@mikeboers
Copy link
Member Author

We now have planes exposed on video and audio frames.

Could use a nice high-level API, but it now aligns with FFmpeg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant