Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check coord_sys of SpatialVariable #2220

Closed
rtimms opened this issue Aug 9, 2022 · 5 comments
Closed

Check coord_sys of SpatialVariable #2220

rtimms opened this issue Aug 9, 2022 · 5 comments
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve

Comments

@rtimms
Copy link
Contributor

rtimms commented Aug 9, 2022

When creating a SpatialVariable check the coordinate system against KNOWN_COORD_SYS defined here.
@brosaplanella
Copy link
Sponsor Member

You beat me hahaha. The docstring also needs fixing.

@rtimms
Copy link
Contributor Author

rtimms commented Aug 9, 2022

Also, add a setter for coord_sys is SubMesh to perform this check for the meshes too.

@valentinsulzer valentinsulzer added the difficulty: easy A good issue for someone new. Can be done in a few hours label Oct 11, 2022
@rtimms rtimms added the priority: low No existing plans to resolve label May 15, 2023
@brosaplanella brosaplanella mentioned this issue Jul 24, 2023
Open
@kratman
Copy link
Contributor

kratman commented May 3, 2024

Is this solved by #3394 and #3114? This seems like a duplicate

@agriyakhetarpal
Copy link
Member

Yes, Ferran mentioned in #3114 (comment) that #3394 should close both issues. We should probably close this one and keep the newer one open.

@kratman kratman added the needs-reply Needs further information from the author and may be closed if no response is received label May 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

It looks like there hasn't been a reply in 30 days, so I'm closing this issue.

@github-actions github-actions bot closed this as completed Jun 3, 2024
@github-actions github-actions bot removed the needs-reply Needs further information from the author and may be closed if no response is received label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kratman @valentinsulzer @brosaplanella @rtimms @Saransh-cpp @agriyakhetarpal