Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Briefcase doesn't ensure cookiecutter template is correct branch before use #108

Closed
freakboy3742 opened this issue Mar 13, 2018 · 1 comment
Labels
bug A crash or error in behavior.

Comments

@freakboy3742
Copy link
Member

(Discovered with @rogueleaderr during pair programming session)

If you generate a Briefcase app with a particular version of Python (e.g., run python setup.py macos under Python 3.6, and then run a second time under Python 3.5), the cookiecutter app template isn't switched to the correct branch.

This is because the cloning process only runs if the directory does not exist. On subsequent runs, the cookiecutter repo is pulled, but no branch switch takes place.

Cookiecutter does have logic in place to re-clone and switch branches, but this only gets called if a complete re-clone is executed. This may not be a suitable solution for Briefcase, because it requires the user be online when running Briefcase.

@freakboy3742
Copy link
Member Author

The 0.3 development branch addresses this by tweaking the wrapper around cookiecutter's template usage behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A crash or error in behavior.
Projects
None yet
Development

No branches or pull requests

1 participant