Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressbar crash on start #507

Closed

Conversation

ibigpapa
Copy link
Contributor

windows expects int32 values for maximum and value. core spec is working with floats.
Adjusted the windows implementation to convert float to integer by setting a 3 decimal place precision for max value to cover edge cases. Inserted not supported max for windows. Now the value gets converted to a percentage of max (1000). Will not allow you to go over max and under min will instead just set to max or min respectively. Also added if None is passed in then the default is to use the min value as the value.

#504

PR Checklist:

  • [x ] All new features have been tested
  • [x ] All new features have been documented
  • [x ] I have read the CONTRIBUTING.md file
  • [x ] I will abide by the code of conduct

…d logic to handle percentage values instead of raw integers
@ibigpapa ibigpapa changed the title Fixed passing in non-integer values to progress bar for windows. Add… Progressbar crash on start #504 May 15, 2018
@ibigpapa ibigpapa changed the title Progressbar crash on start #504 Progressbar crash on start May 15, 2018
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution this is a great start! I talked to @freakboy3742 more about the ProgressBar. I don't think this is documented well right now, but the value is not always a percentage. It is the value out of the max. The only time when value is a percentage is when the max is set to 100. Other use cases may be if the program calculated time that an operation is expected to take, then you set the max to this time. Does WinForms support an indeterminate state, for example if the total time was being calculated? We would want this to be displayed when the value = None. Also if we want to make the interface always be a float or int, that could be changed if supporting both is too difficult.

@danyeaw danyeaw added the not quite right The idea or PR has been reviewed, but more work is needed. label May 15, 2018
@phildini
Copy link
Member

Hi there! It looks like this PR might be dead, so we're closing it for now. Feel free to re-open it if you'd like to continue. 😄

@phildini phildini closed this Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not quite right The idea or PR has been reviewed, but more work is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants