Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda installation of version 2.3.0 has wrong get_include() on python 3.7 #1904

Closed
rmjarvis opened this issue Sep 2, 2019 · 3 comments
Closed

Comments

@rmjarvis
Copy link

rmjarvis commented Sep 2, 2019

Issue description

The get_include() call on python 3.7 for version 2.3.0 is missing a subdirectory 'python3.7m' when installed using conda (but not when installed using pip).

Reproducible example code

First pip installation works correctly:

$ pip install  pybind11
Collecting pybind11
  Using cached https://files.pythonhosted.org/packages/5d/85/c7a8dffda52ce25a8bcfe9a28b6861bdd52da59ae001fdd4173e054b7d9b/pybind11-2.3.0-py2.py3-none-any.whl
Installing collected packages: pybind11
Successfully installed pybind11-2.3.0
$ python -c 'import pybind11; print(pybind11.__version__)'
2.3.0
$ python -c 'import pybind11; print(pybind11.get_include())'
/astro/u/mjarvis/.conda/envs/py3.7/include/python3.7m
$ find /astro/u/mjarvis/.conda/envs/py3.7/include/ -name pybind11.h
/astro/u/mjarvis/.conda/envs/py3.7/include/python3.7m/pybind11/pybind11.h

Uninstalling that, and installing via conda does not work:

$ pip uninstall pybind11
[... snip ...]
  Successfully uninstalled pybind11-2.3.0
$ conda install -y pybind11
Solving environment: done
]... snip ...]
The following NEW packages will be INSTALLED:

    pybind11: 2.3.0-py37hc9558a2_2 conda-forge

Preparing transaction: done
Verifying transaction: done
Executing transaction: done
$ python -c 'import pybind11; print(pybind11.__version__)'
2.3.0
$ python -c 'import pybind11; print(pybind11.get_include())'
/astro/u/mjarvis/.conda/envs/py3.7/include
$ find /astro/u/mjarvis/.conda/envs/py3.7/include/ -name pybind11.h
/astro/u/mjarvis/.conda/envs/py3.7/include/python3.7m/pybind11/pybind11.h

Note the last two results. The pybind11.h file is in the same place as for pip. But get_include() is missing the python3.7m part.

@sdebionne
Copy link
Contributor

This should be fixed with #1877.

@rmjarvis
Copy link
Author

rmjarvis commented Sep 5, 2019

Thanks. I looked for something relevant, but didn't notice that one.

@YannickJadoul
Copy link
Collaborator

Answered and resolved. Closing. Thanks for answering, @sdebionne!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants