Add BibTeX export for ScopusSearch #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First implementation, might need some cleanup.
Michael-E-Rose
force-pushed
the
master
branch
4 times, most recently
from
403e8a5
to
12b1e6e
Compare
Comment on lines
+227
to
+255
| type_conference_paper = "Conference Paper" | ||
| type_conference_review = "Conference Review" | ||
| type_article = "Article" | ||
| type_review = "Review" | ||
| type_short_survey = "Short Survey" | ||
| type_editorial = "Editorial" | ||
| type_note = "Note" | ||
| type_letter = "Letter" | ||
| type_data_paper = "Data Paper" | ||
| type_erratum = "Erratum" | ||
| type_book_chapter = "Book Chapter" | ||
| type_book = "Book" | ||
| type_report = "Report" | ||
| type_retracted = "Retracted" | ||
| type_none = None | ||
|
|
||
| aggregation_type_conference_proceedings = "Conference Proceeding" | ||
| aggregation_type_journal = "Journal" | ||
| aggregation_type_trade_journal = "Trade Journal" | ||
| aggregation_type_book_series = "Book Series" | ||
| aggregation_type_book = "Book" | ||
| aggregation_type_report = "Report" | ||
| aggregation_type_none = None | ||
|
|
||
| bib_tex_type_article = "Article" | ||
| bib_tex_type_in_proceedings = "InProceedings" | ||
| bib_tex_type_in_collection = "InCollection" | ||
| bib_tex_type_book = "Book" | ||
| bib_tex_type_techreport = "TechReport" |
There was a problem hiding this comment.
All these variables just contain one string. Isn't it easier to just use the strings instead of the variables?
Comment on lines
+308
to
+313
| if (document_type in [type_article, type_review, type_short_survey, type_editorial, type_note, type_letter, type_data_paper, type_erratum, type_conference_review, type_conference_paper, type_retracted, type_none] and aggregation_type == aggregation_type_journal) or (document_type in [type_article, type_review, type_short_survey, type_note] and aggregation_type == aggregation_type_trade_journal) or (document_type == type_article and aggregation_type == aggregation_type_none): | ||
| bib_tex_type = bib_tex_type_article | ||
| if aggregation_type == aggregation_type_conference_proceedings or (document_type == type_conference_paper and aggregation_type in [aggregation_type_book, aggregation_type_none]): | ||
| bib_tex_type = bib_tex_type_in_proceedings | ||
| elif aggregation_type == aggregation_type_book_series or (document_type in [type_book_chapter, type_article, type_editorial] and aggregation_type == aggregation_type_book): | ||
| bib_tex_type = bib_tex_type_in_collection |
There was a problem hiding this comment.
It would be more readable to define suitable doctypes as a set beforehand:
in_collection = {"ed", "ar", "ch"}
etc.
Comment on lines
+324
to
+326
| fields = self.add_bibtex_field(fields, "author", authors) | ||
| fields = self.add_bibtex_field(fields, "title", result.title) | ||
| fields = self.add_bibtex_field(fields, "date", result.coverDate) |
There was a problem hiding this comment.
Can you turn this and the following statements into a loop of tuples?
[("author", authors), ("title", result.title), ...]
| bib_library.add(entry) | ||
|
|
||
| # Check whether the addition was successful or resulted in a duplicate block that needs fixing. | ||
| for i in range(26): |
There was a problem hiding this comment.
Where does the 26 come from?
| # Check whether the addition was successful or resulted in a duplicate block that needs fixing. | ||
| for i in range(26): | ||
| failed_blocks = bib_library.failed_blocks | ||
| if failed_blocks: |
There was a problem hiding this comment.
What exactly is happening here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementation, might need some cleanup.
I thought, I will already start the PR, so feedback can be given.
Fixes #295