Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with creating qfile for complex scopus queries #6

Closed
Wasala opened this issue Oct 21, 2016 · 4 comments
Closed

issue with creating qfile for complex scopus queries #6

Wasala opened this issue Oct 21, 2016 · 4 comments

Comments

@Wasala
Copy link

Wasala commented Oct 21, 2016

When you have complex (and long) scopus queries, the qfile creation mechanism fails. For example, for the search query "test" (with double quotes). Rather than just replacing slashes of the queries (query.replace('/', 'slash') in scopus_search.py how about implementing a solution like the one mentioned here (see the accepted solution): http://stackoverflow.com/questions/7406102/create-sane-safe-filename-from-any-unsafe-string
Then again, when the query is very long, this will still generate a very long file name. Therefore may be it's better to hash the query string and use the hash to create the file.

@jkitchin
Copy link
Collaborator

The hash is probably the best approach. Any chance you want to do it and make a pull request?

@Wasala
Copy link
Author

Wasala commented Oct 23, 2016

also noticed a few more issues, might work on these as and when i have time :)

@Michael-E-Rose
Copy link
Contributor

PR #40 will solve this issue.

@Michael-E-Rose
Copy link
Contributor

This change has gone live with scopus 1.0 (b7f2bcb) on Saturday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants