Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene saved validator #37

Closed
mottosso opened this issue Aug 17, 2015 · 5 comments
Closed

Scene saved validator #37

mottosso opened this issue Aug 17, 2015 · 5 comments

Comments

@mottosso
Copy link
Member

Because UUIDs are written on scene-save, we'll need to be sure the scene actually has been saved before publishing.

@BigRoy
Copy link
Member

BigRoy commented Aug 17, 2015

This was included in one of the earlier commits.

The two relevant plug-ins at the time were:
https://github.com/pyblish/pyblish-magenta/blob/ba658c67cc4b6cc684f98db89bfba4b54699f3aa/pyblish_magenta/plugins/_validate_scene_saved.py
https://github.com/pyblish/pyblish-magenta/blob/ba658c67cc4b6cc684f98db89bfba4b54699f3aa/pyblish_magenta/plugins/collect_scene_modified.py

Note that I disabled it back then because it was annoying that some of the Collectors or method calls would make Maya assume the scene was modified even if only queried for content. For example, does cmds.file(exportSelected=True, preview=True) trigger a scene modified? There are likely many commands that trigger it.

We should look into how it's made comfortable for the artist. Because from time to time I pressed save and then tried to publish directly and it got invalidated because the scene was supposedly modified.

@mottosso
Copy link
Member Author

Mm, I remember, also experienced this.

Something to look out for. Perhaps it's ok to ensure it has been saved at least once. Though it would mean missing out on potentially new nodes leaving without a UUID.

Another alternative could be to add another callback to scene saved, imprint the time at which is was saved. The validator could then take this into account.

Not very clean, just throwing it out as an option.

@BigRoy
Copy link
Member

BigRoy commented Aug 17, 2015

I think we're tackling the issue the wrong way.

Shouldn't the validator just validate that all nodes included in the extraction have a UUID? And in modeling also ensure they are unique? (Two separate validators I assume)

@mottosso
Copy link
Member Author

Good thinking!

@BigRoy
Copy link
Member

BigRoy commented Feb 17, 2016

Shall we close this since we covered this particular problem from that time with a lot of different solutions?

@BigRoy BigRoy closed this as completed Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants