Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decode and encode in json module jedi test #123

Open
laurensvalk opened this issue Dec 2, 2022 · 3 comments
Open

Fix decode and encode in json module jedi test #123

laurensvalk opened this issue Dec 2, 2022 · 3 comments
Labels
bug Something isn't working topic: code completion Issues involving automaic code completion (intellesense)

Comments

@laurensvalk
Copy link
Member

Not sure where these are coming from.

"decode", # FIXME: Shouldn't be here
"dump",
"dumps",
"encode", # FIXME: Shouldn't be here

@laurensvalk laurensvalk changed the title Fix decode and encode in json module Fix decode and encode in json module jedi test Dec 2, 2022
@dlech
Copy link
Member

dlech commented Dec 2, 2022

It is picking up the ujson module from here: https://github.com/davidhalter/typeshed/blob/ae9d4f4b21bb5e1239816c301da7b1ea904b44c3/third_party/2and3/ujson.pyi

Hopefully there is a way we can tell jedi to not use that.

@dlech dlech added bug Something isn't working topic: code completion Issues involving automaic code completion (intellesense) labels Dec 2, 2022
@dlech
Copy link
Member

dlech commented Dec 2, 2022

I think we would basically need to fork jedi to fix this (as per discussion in davidhalter/jedi#1809).

@dlech
Copy link
Member

dlech commented Dec 2, 2022

Maybe we can get some inspiration from Thonny. It looks like they are monkey-patching instead of forking.

https://github.com/thonny/thonny/blob/master/thonny/jedi_utils.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic: code completion Issues involving automaic code completion (intellesense)
Projects
None yet
Development

No branches or pull requests

2 participants