Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement Car class in C #1502

Closed
laurensvalk opened this issue Mar 3, 2024 · 7 comments
Closed

[Feature] Implement Car class in C #1502

laurensvalk opened this issue Mar 3, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request hub: movehub Issues related to the LEGO BOOST Move hub software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime)

Comments

@laurensvalk
Copy link
Member

laurensvalk commented Mar 3, 2024

Is your feature request related to a problem? Please describe.
The version of the Car class we ended up with only has three small synchronous methods. This should be easy and cheap to implement in C.

If we really saved 4KB on move hub, it is probably worth including this class. Both because it is useful and because it is a lot easier to have the corresponding blocks "just work" without exceptions.

Despite being a last minute change, this should be fairly low risk and will expedite the release of the docs and block code, so it is probably worth the time.

@laurensvalk laurensvalk added enhancement New feature or request hub: movehub Issues related to the LEGO BOOST Move hub software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime) labels Mar 3, 2024
@laurensvalk laurensvalk self-assigned this Mar 3, 2024
@laurensvalk
Copy link
Member Author

Done via pybricks/pybricks-micropython@3281b1b

@BertLindeman
Copy link

Ran your example from issue #1397 on the beta firmware on the movehub.
Great.
Was there any check on the motors intended?
I made a typo in the car definition: used motorA both as steering motor and as part of the drive motors.
Silently the steer callibration is skipped and driving is done.
Took me some time to understand why the steering did not work ;-)

@laurensvalk
Copy link
Member Author

That's a great idea, thanks Bert!

@laurensvalk
Copy link
Member Author

@BertLindeman - released in stable firmware, accessible in latest Pybricks Beta. (Just some more test driving and then we'll call it stable!)

@BertLindeman
Copy link

@BertLindeman - released in stable firmware, accessible in latest Pybricks Beta. (Just some more test driving and then we'll call it stable!)

Did not see it as quickly as I wanted (also preparing "help, I got a smartphone" lesson..)
Doing a test now.

@BertLindeman
Copy link

BertLindeman commented Mar 11, 2024

Tested

v3.4.0 (Pybricks Beta v2.4.0-beta.7)

Drive and steer motors should be uniqe.
Drive motors should be unique.

Tested via block coding.
All OK.

[EDIT} pasted the correct version tested with

@laurensvalk
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hub: movehub Issues related to the LEGO BOOST Move hub software: pybricks-micropython Issues with Pybricks MicroPython firmware (or EV3 runtime)
Projects
None yet
Development

No branches or pull requests

2 participants