licensing: no mention of advertising clause/Nils Provos in documentation

[FelixSchwarz]

Since 394882d this project is partly licensed under a BSD license with advertising clause. However this is not mentioned at all in README.md, the LICENSE file and not exposed via setup.py.

I'm not a laywer but I think the 4-clause BSD license might be a nasty surprise for users of this module. The best solution to me would be trying to relicense the blowfish code under a 3-clause BSD (or maybe even the ISC license as there are other files with that license in the repo).

Are you aware of any relicensing efforts/contacts to Nils Provos to remedy the situation?

[spotrh]

I have connected with Niels (@provos) and he has given permission to remove the "advertising" clause (clause 3) for his code.

[spotrh]

Blowfish-cypher-license-change.pdf

[FelixSchwarz]

@spotrh Thank you very much for reaching out (and of course to Niels for writing the code+relicensing it).

[reaperhulk]

Huge thanks for tracking this down. The PR to update the license with the clauses removed has been merged.