Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a changelog. #47

Closed
scriptsrc opened this issue Jun 25, 2015 · 3 comments
Closed

Please add a changelog. #47

scriptsrc opened this issue Jun 25, 2015 · 3 comments

Comments

@scriptsrc
Copy link

When upgrading apps, I like to review each dependency's changelog to look for potentially breaking changes. Thanks.

@tisdall
Copy link

tisdall commented Jul 8, 2015

I came to also ask for something along these lines... Basically, I saw that the version number jumped a major revision from 1 to 2 and that tends to indicate a breaking change. However, there's no mention in the description on pypi (or anywhere really) that the breaking change has to do with the $2b$ prefix. I don't think people should have to go through the git commits, issues, or PR's to figure this out (like I had to do).

@josefdlange
Copy link

It was nearly a production issue for me that I had to discover the breaking change between v1 and v2 -- the README's statement of compatibility with py-bcrypt is now false. It was frustrating to have to hunt for why one stack was telling my "invalid salt" and the other was fine -- it was because the first stack was importing py-bcrypt via import bcrypt, which doesn't know how to handle 2b prefixes. Very frustrating to track down, for something that is a very common and crucial piece of most projects using this library.

Worth mentioning that having py-bcrypt installed at all was a folly on my part as it was depended on me neither directly or transitively, but stranger things have happened...

@reaperhulk
Copy link
Member

We now have a changelog

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants