Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Sodium Optmizations #24

Closed
dstufft opened this issue Apr 18, 2013 · 4 comments
Closed

Support Sodium Optmizations #24

dstufft opened this issue Apr 18, 2013 · 4 comments

Comments

@dstufft
Copy link
Member

dstufft commented Apr 18, 2013

Sodium has recently added the ability to select optimized implementations of the various routines. In order to support this (and newer versions of Sodium) PyNaCl will need to call sodium_init prior to doing any work with Sodium, sodium_reinit anytime a fork happens, and sodium_shutdown before exiting the program.
@warner
Copy link
Member

warner commented Mar 28, 2014

Good news: reinit and shutdown are gone: jedisct1/libsodium#31 and jedisct1/libsodium@fc98102. Those would have been really difficult to work with.

@Ayrx
Copy link
Contributor

Ayrx commented Jul 15, 2014

Is this fixed with #52?

@warner
Copy link
Member

warner commented Jul 15, 2014

I think so, but I'd want to trace through the code a bit to be sure.

@reaperhulk
Copy link
Member

sodium_init is now safe to call repeatedly as well, closing this as no longer relevant.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@warner @dstufft @reaperhulk @Ayrx