Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TLSPrefixedArray in tls.message.Certificate.from_bytes #128

Merged
merged 3 commits into from
Jan 30, 2017
Merged

Use TLSPrefixedArray in tls.message.Certificate.from_bytes #128

merged 3 commits into from
Jan 30, 2017

Conversation

0x0ece
Copy link
Contributor

@0x0ece 0x0ece commented Jan 30, 2017

Fixes #109.

@coveralls
Copy link

coveralls commented Jan 30, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 981eecc on 0x0ece:no-bytesio into ad06bce on pyca:master.

@ashfall
Copy link
Contributor

ashfall commented Jan 30, 2017

Looks great, thanks! Deleting the BytesIO import should make travis happy.

ashfall
ashfall approved these changes Jan 30, 2017
View reviewed changes
Copy link
Contributor

@ashfall ashfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge as soon as the builds finish! Thanks again, this was a much needed change!!!

@coveralls
Copy link

coveralls commented Jan 30, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9988378 on 0x0ece:no-bytesio into ad06bce on pyca:master.

@ashfall ashfall merged commit 6106a21 into python-tls:master Jan 30, 2017
derwolfe pushed a commit to derwolfe/tls that referenced this pull request Jun 25, 2017
@0x0ece @derwolfe
Use TLSPrefixedArray in tls.message.Certificate.from_bytes (pytho…
4f036ef 
…n-tls#128)

* Use `TLSPrefixedArray` in `tls.message.Certificate.from_bytes`

Fixes python-tls#109.

* Fixing errors

* Finally removing BytesIO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfall ashfall ashfall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0x0ece @coveralls @ashfall