MAINT/FIX: Relax version pin for symengine #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for older Pythons aren't being built anymore
richardotis
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #498 +/- ##
===========================================
- Coverage 90.48% 90.47% -0.02%
===========================================
Files 50 50
Lines 7871 7871
===========================================
- Hits 7122 7121 -1
- Misses 749 750 +1 ☔ View full report in Codecov by Sentry. |
bocklund
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaxes the symengine version pin so that future symengine releases also satisfy the dependency requirement. SymEngine release cadence has increased and we're also seeing fewer regressions, so I think it's safe and advisable for pycalphad to relax the hard pin. Also, this will fix #497.
Checklist
setup.py(runtime requirements)pyproject.toml(build requirements)requirements-dev.txt(build and development requirements)