Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT/BLD: Python CI support and docs build fixes #508

Merged
merged 7 commits into from Jan 18, 2024

Conversation

bocklund
Copy link
Collaborator

  • Add support in CI for Python 3.12
  • Drop support for Python 3.7 as it's EOL as of June 2023 https://devguide.python.org/versions/
  • Drop a really old pin on furo because we can upgrade now (pin was forcing old sphinx versions to be installed, which is what was breaking our docs builds in CI)
  • Fixes for new versions of sphix:
    1. Language is no longer allowed to be None, set to 'en' which is the default
    2. Fix extlinks that requires a %s in the caption (added support for that in v4.0, removed support for deprecated way without the %s in v6.0 Remove deprecated items for Sphinx 6.0 sphinx-doc/sphinx#10471)

1. Sphinx requires language specification now (was a warning, but we error on warnings)
2. Fix extlinks that requires a %s in the caption (supported in v4.0, removed in v6.0 sphinx-doc/sphinx#10471)
@bocklund
Copy link
Collaborator Author

bocklund commented Jan 17, 2024

No changes need for our wheel building flags, which are currently including 3.12 and not including 3.7 anyway

      - name: Build wheels
        uses: pypa/cibuildwheel@v2.16.2
        env:
          # PyPy wheels not allowed because SciPy (build requirement) is not available
          CIBW_BUILD: cp3*-*
          CIBW_SKIP: cp35-* cp36-* cp37-* *-musllinux_*

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fd0f06) 90.47% compared to head (335cada) 90.46%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #508      +/-   ##
===========================================
- Coverage    90.47%   90.46%   -0.01%     
===========================================
  Files           50       50              
  Lines         7871     7868       -3     
===========================================
- Hits          7121     7118       -3     
  Misses         750      750              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardotis
Copy link
Collaborator

Coverage analysis is signalling that the importlib_metadata backport can be removed now. I'm fine either way. If it is removed from __init__.py, be sure to update the dependencies accordingly.

@bocklund bocklund merged commit 071c50a into pycalphad:develop Jan 18, 2024
26 checks passed
@bocklund bocklund deleted the maint-py312 branch January 18, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants