Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DICT] Add Python support for pop #1886

Open
Tracked by #1570
EmilyBourne opened this issue May 16, 2024 · 3 comments · May be fixed by #1891
Open
Tracked by #1570

[DICT] Add Python support for pop #1886

EmilyBourne opened this issue May 16, 2024 · 3 comments · May be fixed by #1891
Assignees
@EmilyBourne
Labels
Containers tuples/lists/sets/maps enhancement good-first-issue

Comments

@EmilyBourne
Copy link
Member

EmilyBourne commented May 16, 2024 •
edited

Describe the feature

Syntactic and semantic support should be added for pop. This should be tested by implementing Python printing

Test Code

Provide code which does not currently work but which should do when this issue is fixed:

def foo():
    a = {1:1.0, 2:2.0}
    b = a.pop(1)
    c = a.pop(3, 4.0)
    return a, b, c
@EmilyBourne EmilyBourne mentioned this issue May 16, 2024
Open
20 tasks
@EmilyBourne EmilyBourne linked a pull request May 17, 2024 that will close this issue
Open
@EmilyBourne EmilyBourne self-assigned this May 17, 2024
This was referenced May 21, 2024
Open
Open
@learning-dev
Copy link

Hi @EmilyBourne, can I please take this up? Also, any reference that I can look up and fix it? I am new to OSS. Thanks.

@EmilyBourne
Copy link
Member Author

Hi @EmilyBourne, can I please take this up? Also, any reference that I can look up and fix it? I am new to OSS. Thanks.

Hi @learning-dev, thanks for your interest in Pyccel. This issue has actually already been fixed (see #1891). We just have a long merge queue at the moment as the person with merge rights is not available.

There are several similar issues though if you are interested? For example issue #1885 should be very similar. There is a longer description of how to tackle this kind of issue here: #1887 (comment)

@learning-dev
Copy link

Thank you @EmilyBourne .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EmilyBourne EmilyBourne

Labels
Containers tuples/lists/sets/maps enhancement good-first-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DICT] Add support for pop() method pyccel/pyccel
2 participants
@learning-dev @EmilyBourne