Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DICT popitem #1902

Draft
wants to merge 1 commit into
base: devel-issue1886
Choose a base branch
from

Conversation

shoaib-moeen
Copy link

No description provided.

@pyccel-bot
Copy link

pyccel-bot bot commented May 24, 2024

Hello! Welcome to Pyccel! Thank you very much for your contribution ❤️.

I am the GitHub bot. I will help guide you through the different stages necessary to validate a review in Pyccel. If you haven't yet seen our developer docs make sure you check them out here. Amongst other things they describe the review process that we have just started. You can also get in touch with our other developers on our Pyccel Discord Server.

To begin with I will give you a short checklist to make sure your pull request is complete. Please tick items off when you have completed them or determined that they are not necessary for this pull request. If you want me to run any specific tests to check out corner cases that you can't easily check on your computer, you can request this using the command /bot run X. Use the command /bot show tests to see a full list of the tests I can run. Once you have finished preparing your pull request and are ready to request reviews just take your PR out of draft, or let me know with the command /bot mark as ready. I will then run the full suite of tests to check that everything is as neat as you think before asking other contributors for reviews. Tests will not run automatically before this point to avoid wasting resources. You can get a full list of commands that I understand using /bot commands.

Please begin by requesting your checklist using the command /bot checklist.

@github-actions github-actions bot marked this pull request as draft May 24, 2024 21:13
@pyccel-bot
Copy link

pyccel-bot bot commented May 24, 2024

@yguclu, @EmilyBourne, @bauom, please can you check if I can trust this user. If you are happy, let me know with /bot trust user

@shoaib-moeen
Copy link
Author

/bot run docs spelling pylint pyccel_lint coverage

@pyccel-bot
Copy link

pyccel-bot bot commented May 24, 2024

Thank you for your request. Unfortunately I am not allowed to run tests for you as you have never contributed to this repository and haven't been approved on this Pull Request.

@EmilyBourne
Copy link
Member

/bot trut user shoaib-moeen

@pyccel-bot
Copy link

pyccel-bot bot commented May 25, 2024

This bot reacts to all comments which begin with /bot. This phrase can be followed by any of these commands:

  • show tests : Lists the tests which can be triggered
  • run X : Triggers the test X (acceptable values for X can be seen using show tests). Multiple tests can be specified separated by spaces.
  • try V X : Triggers the test X (acceptable values for X can be seen using show tests) using Python version V. Multiple tests can be specified separated by spaces, but all will use the same Python version.
  • mark as ready : Runs the PR tests. If they pass then it adds the appropriate review flag and requests reviews. This command should be used when the PR is first ready for review, or when a review has been answered.
  • commands : Shows this list detailing all the commands which are understood.
  • trust user X : Tells the bot that a new user X is trusted to run workflows (prevents misuse of GitHub actions for mining etc). This command can only be used by a trusted reviewer.

Beware: if you have never contributed to this repository and you are not a member of the Pyccel organisation, the bot will ignore all requests to run tests until permitted by a trusted reviewer.

@EmilyBourne
Copy link
Member

/bot trust user shoaib-moeen

@pyccel-bot
Copy link

pyccel-bot bot commented May 25, 2024

@shoaib-moeen It looks like the Pyccel maintainers trust you 🚀. I will now start running tests when you request them.

@shoaib-moeen
Copy link
Author

/bot run docs spelling pylint pyccel_lint coverage

Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants