New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean compilation #928
Merged
Merged
Clean compilation #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpi-compiler option
It seems either impossible or inadvisable to generate the json during the installation. See here |
EmilyBourne
added
the
Ready_to_merge
Approved by senior developer. Ready for final approval and merge
label
Aug 4, 2021
rakati
approved these changes
Aug 4, 2021
saidctb
approved these changes
Aug 4, 2021
yguclu
approved these changes
Aug 6, 2021
yguclu
pushed a commit
that referenced
this pull request
Sep 7, 2021
- Remove debugging information - Correct Windows MPI compiler configuration - Reactivate unit test on Windows by removing "skipif" flag - Ensure that files are compiled using `mpif90` when the code is run using `mpi4py` (this was unintentionally removed in PR #928)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhaul the compilation method. A class
Compiler
is now used to handle all compilation steps. A classCompileObj
is used to store all information required to compile a given file. Default compile configurations for basic compilers (gcc, gfortran, icc, ifort) are saved in json files inpyccel/compilers
these are determined thanks to thesysconfig
module. Fixes #541.After this PR, tests run much faster. The times below show the last 3 tests run on the master and
ebourne_compiling
branches, followed by the average timesMaster branch
ebourne_compiling
Supported compilers:
The following compilers have been tested:
gcc
/gfortran
icc
/ifort
(tested by @EmilyBourne )pgcc
/pgfortran
(tested by @saidctb )nvc
/nvfort
(tested by @rakati )Commit Summary
CompileObj
to hold all information required to compile a given fileCompiler
to hold all information about a given compilercwrapper.py
. Thesetup_X.py
file is no longer requiredCompiler
andCompileObj
to simplifypipeline.py
andpython_wrapper.py
accelerators
mpi
an accelerator instead of specifying thempi_compiler
GNU
) instead of the compiler namewrapper_flags
argument to separate the flags for the file (fortran) from the flags for the wrapper (c)pyc_math
topyc_math_c
andpyc_math_f90
. This allows us to differentiate between the.o
files created from the source files which means we don't need to systematically recompile the librarypyccel.compilers.generate_default
to generate the default json files