Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategies for Cells #11

Closed
samth opened this issue Feb 4, 2014 · 2 comments
Closed

Strategies for Cells #11

samth opened this issue Feb 4, 2014 · 2 comments
Labels
Milestone

Comments

@samth
Copy link
Collaborator

samth commented Feb 4, 2014

Right now fixnums in set!'ed variables always requires allocation. This makes me sad.

@cfbolz
Copy link
Collaborator

cfbolz commented Feb 10, 2014

The types that we see in test_larger.py:

None: 126
W_Fixnum: 145
W_Null: 3
W_Prim: 7
W_Closure: 118

For W_Fixnum we should use a strategy, for the W_Closure case maybe we can extend when RecLambda is used a bit.

@samth samth added the pldi label Jul 5, 2014
@cfbolz
Copy link
Collaborator

cfbolz commented Jul 7, 2014

Here's the diff to do this type profiling (untranslated):

https://gist.github.com/cfbolz/7799bba1031ef2e3f13d

Current numbers for all tests:

at construction
W_Null: 2
W_Fixnum: 41
None: 28

when set
W_MCons: 2
W_ClosureSize1: 7
W_PromotableClosure: 1
W_Fixnum: 139
W_Bool: 2

This means fixnum strategies are still a good idea, and the reclambda removal is very successful

@cfbolz cfbolz closed this as completed in 369052d Jul 7, 2014
@cfbolz cfbolz modified the milestone: PLDI Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants