Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arm-osx? #141

Closed
corneliusroemer opened this issue Feb 14, 2023 · 7 comments
Closed

Support for arm-osx? #141

corneliusroemer opened this issue Feb 14, 2023 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@corneliusroemer
Copy link

Do you plan to support arm-osx in the future?

@rhpvorderman rhpvorderman added the help wanted Extra attention is needed label Feb 14, 2023
@rhpvorderman
Copy link
Collaborator

rhpvorderman commented Feb 14, 2023

There are multiple blockers for this.

  1. No arm-osx support in upstream: https://github.com/intel/isa-l. This should be fixed on the develop branch so a new release needs to come out first.
  2. I have no means of testing out wheels that come out as arm-osx
  3. I don't know how to build arm-osx wheels. Supposedly this can be handled with cibuildwheel. But I do wonder if this will also manage to build the proper isa-l for inclusion. As long as I have no method to test it I am hesitant to release it.

Basically this requires someone else to step in and enable support. I cannot support it myself and I am unwilling to buy the expensive hardware in order to do so.

EDIT: I do suppose that when I upgrade the included distribution of ISA-L to the latest version with the arm-osx support version, people on that platform should be able to build it themselves using clang.

EDIT2: You could also have a look at https://github.com/pycompression/python-zlib-ng that should be able to compile on arm-osx just fine already.

@corneliusroemer
Copy link
Author

Thanks for looking into this! The reason I ask is because conda-forge has been adding an osx-arm channel and I noticed xopen was not yet in there due to this package blocking. So I thought I go and ask!

It's not critical as one can emulate using rosetta2 but I thought it'd be worth checking. Thanks for your work!

@rhpvorderman
Copy link
Collaborator

Oh really? I also co-maintain xopen (hence the shared pycompression group). That should not be the case as the dependency is entirely optional. Can you make an issue at the xopen feedstock and ping me? Then I can look into it when I have the time.

@corneliusroemer
Copy link
Author

corneliusroemer commented Feb 14, 2023

@rhpvorderman no worries! I had actually already opened an issue end of November :)

conda-forge/xopen-feedstock#28

There's a nice overview of migration here:

https://conda-forge.org/status/

This is what I found:
image

@rhpvorderman
Copy link
Collaborator

As of yet, arm-osx seems to build on the latest dev branch. However, ISA-L need to release officially before that can be implemented.

@rhpvorderman
Copy link
Collaborator

I just merged a PR that patches the current version of ISA-L 2.31 with a few patches that enable compilation on OSX ARM64. Thanks a lot to @hmaarrfk for identifying the necessary commits.

@rhpvorderman
Copy link
Collaborator

Wheelbuilding is now enabled for arm-osx in this library and python-zlib-ng. Patches for Python 3.13 are also included. On july 30th python 3.13 will get its first release candidate and wheels build for 3.13 should be stable. I plan to release this library, including the macos arm64 wheels at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants