Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger.error vs logger.warning #35

Closed
kentavv opened this issue Oct 26, 2018 · 2 comments
Closed

logger.error vs logger.warning #35

kentavv opened this issue Oct 26, 2018 · 2 comments

Comments

@kentavv
Copy link

kentavv commented Oct 26, 2018

On win32 logger.error is used else logger.warning is used. Perhaps select the same for both platforms?

logger.error(

@danielferber
Copy link

I agree. I would also prefer the behavior proposed by @kentavv .

@ssbarnea
Copy link
Member

If you want to have it fixed, please make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants