[Email Feature] add relay smtp server configuration #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il using workspace
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1167 +/- ##
=======================================
Coverage 70.57% 70.57%
=======================================
Files 85 85
Lines 3392 3392
=======================================
Hits 2394 2394
Misses 998 998 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(smtp-relay): add relay smtp server configuration
Types of changes
Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an
xin the box that appliesDescription
目前
dev@pycon.tw的寄信流程處於過渡期，目前希望透過*@python.tw取代dev@pycon.tw來寄信。當中，Google Workspace (
python.tw) 的架構需要在 server (staging vm + prod vm) 架設 SMTP server 來 route email message 至 google relay server。因此增加了一個 docker service 來達成此目的。Steps to Test This Pull Request
Steps to reproduce the behavior （只適用於 production environment）:
前置作業：
Server 端修改
.env需要新增ALLOWED_SENDER_DOMAINS=python.tw.env的EMAIL_URL至smtp://mailserver:587(local service 會轉傳，不是直接透過 google smtp 了)docker-compose pulldocker-compose upExpected behavior
@python.twaddress 當作 sender 發信。