-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: schedule hovering style #157
fix: schedule hovering style #157
Conversation
pages/conference/keynotes.vue
Outdated
@@ -137,7 +137,8 @@ export default { | |||
}, | |||
methods: { | |||
getKeynoteId(keynote) { | |||
return keynote.speaker.name_en_us.split(' ').join('_') | |||
// adjust for schedule data format | |||
return keynote.speaker.name_zh_hant.split(' ').join('_') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that the scroll behavior on production page is failed because the anchor and the url are inconsistent.
Reproduce steps:
- go to PyCon Taiwan 2021 official site
- head to schedule page
- click on the first keynote by 魏澤人
- being directed to keynote page without scroll behavior
Thus, modifying the data used as id can fix the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always get the english content on schedule page (cannot change with locale switch) and thus the generated id is correct for me. I assume you get the zh-hant content on this page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@media (hover: hover) { | ||
&:hover { | ||
color: #000000; | ||
background-color: #d1ac23; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious. why can't we get rid of media query here?
@media (hover: hover) { | |
&:hover { | |
color: #000000; | |
background-color: #d1ac23; | |
} | |
} | |
&:hover { | |
color: #000000; | |
background-color: #d1ac23; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without hover media query, mobile users could unintentionally active hover state.
@yuyanghh Thanks for submitting the PR! A few things to point out here:
|
452f6b5
to
3d02f65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'll revert the fix for the scroll bar issue before merging this PR.
The root cause of scroll bar issue is that we did not apply i18n for this page (see #174), and I'll take over this part!
3d02f65
to
7112f42
Compare
Types of changes
Description
Follow Figma design to fix the style of schedule table on mouse hovering
2021-08-30.9.08.36.mov