feat(sponsor): implement sponsor list on index page #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwang44
changed the title
flynn-hou
reviewed
May 2, 2021
components/sponsors/SponsorModal.vue
Outdated
Comment on lines
74
to
78
| .lightBox__closeButton { | ||
| @apply relative flex justify-end text-yellow-500; | ||
| top: 10px; | ||
| right: 10px; | ||
| } |
There was a problem hiding this comment.
Please add cursor: pointer; to allow users to know this is pressable.
components/sponsors/SponsorModal.vue
Outdated
Comment on lines
76
to
77
| top: 10px; | ||
| right: 10px; |
There was a problem hiding this comment.
Suggested change
| top: 10px; | |
| right: 10px; | |
| top: -40px; | |
| right: -20px; |
This looks closer to the design spec, give or take.
components/sponsors/SponsorModal.vue
Outdated
| } | ||
|
|
||
| .lightBox__title { | ||
| @apply flex justify-start items-center; |
There was a problem hiding this comment.
Remove the unnecessary justify-start class as the justify-content rule by default is already flex-start.
pages/index.vue
Outdated
Comment on lines
94
to
97
| closeModal() { | ||
| this.isOpened = false | ||
| this.selectedSponsor = {} | ||
| }, |
components/sponsors/SponsorCard.vue
Outdated
| @@ -0,0 +1,43 @@ | |||
| <template> | |||
| <div v-show="!!logoUrl" :class="classObject"> | |||
| <img :src="logoUrl" class="object-contain w-full" /> | |||
There was a problem hiding this comment.
Suggested change
| <img :src="logoUrl" class="object-contain w-full" /> | |
| <img :src="logoUrl" alt="" class="object-contain w-full" /> |
Provide the required attribute for <img>
components/sponsors/SponsorModal.vue
Outdated
| <div class="lightBox__intro"> | ||
| <p class="text-sm">{{ getAttributeByLocale('intro') }}</p> | ||
| </div> | ||
| <div class="lightBox__bottons"> |
There was a problem hiding this comment.
Suggested change
| <div class="lightBox__bottons"> | |
| <div class="lightBox__buttons"> |
Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes
Description
More Information
Preview: Sponsor List
web view
mobile view (iPhone 6/7/8)
Preview: Modal
web view
mobile view (iPhone 6/7/8)