Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sponsor Index] - Refactor: Non-i18n content rearrangement #500

Open
SivanYeh opened this issue Mar 24, 2024 · 0 comments
Open

[Sponsor Index] - Refactor: Non-i18n content rearrangement #500

SivanYeh opened this issue Mar 24, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@SivanYeh
Copy link
Collaborator

Purpose

檢查Sponsor Index頁面的i18n。在不影響中文版與英文版原先版面與功能下,將無關的內容放置到合適的位置。
可以參考Describe的內容進行。

Describe

2023年度有訂下一個coding convention #396, 今年度預計逐步檢查目前codebase是否符合這份convention。i18n為其中第三條:

The content in i18n should be limited to items that require translation. Unrelated content such as external links, icons should be avoided. PR#395 is an example of this.

無關內容的定義可以參考coding convention #396
Refactor作法可以參考先前 Blogger 網址更新PR #395

Reference

Sponsor Index頁面連結: https://tw.pycon.org/2024/zh-hant/sponsor
image

@SivanYeh SivanYeh added enhancement New feature or request good first issue Good for newcomers labels Mar 24, 2024
@SivanYeh SivanYeh changed the title [Sponsor Index] - Refactor: i18n檢查 [Sponsor Index] - Refactor: Non-i18n content rearrangement Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants