Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export slides and images with english footer #2

Closed
josix opened this issue Aug 15, 2021 · 1 comment
Closed

Export slides and images with english footer #2

josix opened this issue Aug 15, 2021 · 1 comment
Assignees
@josix
Labels
enhancement New feature or request

Comments

@josix
Copy link
Contributor

josix commented Aug 15, 2021 •
edited

Is your feature request related to a problem? Please describe.

There is a requirement for generating English version of slides and images including english category, language info, python level so that we could share the preview image with foreign attendee.

The result of the generating image will look like following picture.
image

Describe the solution you'd like
Update the execution flow of TalkPreviewImgBuilder.execute() and TalkPreviewPPTBuilder.execute() to export english slides/images and add english footer in __fill_in_footer() in both of builders
@josix josix self-assigned this Aug 16, 2021
@josix josix added the enhancement New feature or request label Aug 16, 2021
@josix
Copy link
Contributor Author

josix commented Aug 19, 2021

Resolve this issue in commit 9ff1e5fa

@josix josix closed this as completed Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josix josix

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josix