relative import issue

[graingert]

isort caused a syntax error:

--- a/foo/foo/foo_foo/tests/foo_v0/test_jobs.py
+++ b/foo/foo/foo_foo/tests/foo_v0/test_jobs.py
@@ -6,9 +6,10 @@ from django.test.client import RequestFactory
 from mock import patch
 from model_mommy import mommy

-from ... import models, sproqet_api as sproq_api
-from ... fields.sproqet import SproqetCollection
-from ..utils import fake_spork_client, http_status_codes as status
+from ... import sproqet_api as sproq_api
+from ... import fields.sproqet, models, SproqetCollection
+from ..utils import http_status_codes as status
+from ..utils import fake_spork_client
 from ..utils.misc import SporkPatcherTestCaseMixin
 from .utils.constants import job_clone_uri_name, job_detail_uri_name

[timothycrosley]

Glad you found and reported this issue, it's important to me that users feel comfortable that isort will never brake their code, so issues like this are an especially high priority. I'll try to get a hot-fix release out soon to address this.

Thanks!

~Timothy

[graingert]

Perhaps refuse to execute on code with syntax errors and check the
resulting code for syntax errors (by pyc compiling the module)
On 30 Jan 2014 22:27, "Timothy Edmund Crosley" notifications@github.com
wrote:

Glad you found and reported this issue, it's important to me that users
feel comfortable that isort will never brake their code, so issues like
this are an especially high priority. I'll try to get a hot-fix release out
soon to address this.

Thanks!

~Timothy

Reply to this email directly or view it on GitHubhttps://github.com//issues/105#issuecomment-33741391
.

[timothycrosley]

That sounds like a really good idea, as it would almost make running isort an atomic operation. I'll fix this issue separately, but I added #106 as a future enhancement to work on.

[timothycrosley]

Fixed in hotfix release 3.3.1

Thanks!

~Timothy

[graingert]

+:100: