Skip to content

Commit

Permalink
Merge pull request #800 from jdufresne/nose
Browse files Browse the repository at this point in the history
Remove suggestion and documentation of using unmaintained nose
  • Loading branch information
sigmavirus24 committed Sep 16, 2018
2 parents 566cdc0 + 64c2e30 commit c3d2cbd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 18 deletions.
14 changes: 3 additions & 11 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -69,27 +69,19 @@ GitHub has an excellent `guide`_.
The current tests are written in 2 styles:

* standard xUnit based only on stdlib unittest
(can be executed with nose)
* functional test using a custom framework and executed by the
pycodestyle itself when installed in dev mode.


Running unittest
~~~~~~~~~~~~~~~~

While the tests are writted using stdlib `unittest` module, the existing
test include unit, integration and functional tests.
The tests are writted using stdlib `unittest` module, the existing test
include unit, integration and functional tests.

There are a couple of ways to run the tests::
To run the tests::

$ python setup.py test
$ # Use nose to run specific test
$ nosetests \
> testsuite.test_blank_lines:TestBlankLinesDefault.test_initial_no_blank
$ # Use nose to run a subset and check coverage, and check the resulting
$ $ cover/pycodestyle_py.html in your browser
$ nosetests --with-coverage --cover-html -s testsuite.test_blank_lines


Running functional
~~~~~~~~~~~~~~~~~~
Expand Down
3 changes: 0 additions & 3 deletions docs/advanced.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ in your project::
self.assertEqual(result.total_errors, 0,
"Found code style errors (and warnings).")

If you are using ``nosetests`` for running tests, remove ``quiet=True``
since Nose suppresses stdout.

There's also a shortcut for checking a single file::

import pycodestyle
Expand Down
4 changes: 0 additions & 4 deletions testsuite/support.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,3 @@ def run_tests(style):
if options.testsuite:
init_tests(style)
return style.check_files()


# nose should not collect these functions
init_tests.__test__ = run_tests.__test__ = False

0 comments on commit c3d2cbd

Please sign in to comment.